Kevin-Mok/spotify-lib-vis
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed bars not being at right height

Browse Source 
Avoided artist breakdown overflowing total tracks in genre by only
adding artists while running tally is less than total.
This commit is contained in:
Kevin Mok
2018-06-14 06:38:30 -04:00
parent 162b2dad37
commit f71ba20116
3 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spotifyvis/templates/spotifyvis/test_db.html
View File

@@ -22,8 +22,6 @@
<svg width="960" height="500"></svg>
<script>
// {{{ setup
var svg = d3.select("svg"),
margin = {top: 20, right: 20, bottom: 30, left: 40},
width = +svg.attr("width") - margin.left - margin.right,
@@ -36,8 +34,6 @@
var y = d3.scaleLinear()
.rangeRound([height, 0]);
// }}}
d3.json("{% url "get_genre_data" user_secret %}").then(function(data) {
// convert strings to nums
data.forEach(function(d) {
@@ -54,6 +50,7 @@
data.sort(function(a, b) { return b.num_songs - a.num_songs; });
x.domain(data.map(function(d) { return d.genre; }));
y.domain([0, d3.max(data, function(d) { return d.num_songs; }) * 1.25]).nice();
//y.domain([0, d3.max(data, function(d) { return d.num_songs; })]).nice();
// setup bar colors
var max_artists = d3.max(data, function(d) {
@@ -84,7 +81,7 @@
.data(stack)
.enter().append("rect")
.attr("x", x(genre_dict.genre))
.attr("y", function(d) { return y(d.data[0]); })
.attr("y", function(d) { return y(d.data[1]); })
.attr("height", d => y(d.data[0]) - y(d.data[1]))
.attr("width", x.bandwidth())
.attr('fill', (d, i) => z(i))